chore(exam_card): add the weekday the exam is taking place#1832
chore(exam_card): add the weekday the exam is taking place#1832SIMAOMARTA wants to merge 2 commits intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (7%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #1832 +/- ##
=======================================
Coverage 7% 7%
=======================================
Files 38 38
Lines 1886 1886
=======================================
Hits 125 125
Misses 1761 1761 🚀 New features to boost your workflow:
|
pedroafmonteiro
left a comment
pedroafmonteiro
left a comment
There was a problem hiding this comment.
Hello! Thanks for these changes! While functionally looks good, this logic could be a bit simplified so it is more readable by other developers.
Instead of making this logic pass through two files, you could create a helper method called _formatWeekday in exam_month_timeline.dart and use it directly on the subtitle parameter.
Here's a possible example of such method:
String _formatWeekday(DateTime date, AppLocale locale) {
final weekday = DateFormat.E(locale.localeCode.languageCode).format(date);
return weekday[0].toUpperCase() + weekday.substring(1).toLowerCase();
}Also, the issue about missing exams does not appear on my end, probably it was just a sigarra moment on the other day.
Tell me if you agree/have any doubts! Thanks again!
2 participants
Closes #1822
Adds the shortname of the weekday in which the exam is taking place. (only in the "percurso académico" not in the main page)
Review checklist
View Changes
Performance